Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7555A10EBB for ; Mon, 8 Jul 2013 17:03:27 +0000 (UTC) Received: (qmail 41375 invoked by uid 500); 8 Jul 2013 17:03:27 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 41177 invoked by uid 500); 8 Jul 2013 17:03:26 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 41169 invoked by uid 500); 8 Jul 2013 17:03:26 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 41154 invoked by uid 99); 8 Jul 2013 17:03:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2013 17:03:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BB0801CE228; Mon, 8 Jul 2013 17:03:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5422374522448821056==" MIME-Version: 1.0 Subject: Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng From: "bharat kumar" To: "Abhinandan Prateek" , "Alena Prokharchyk" , "Sheng Yang" Cc: "cloudstack" , "bharat kumar" Date: Mon, 08 Jul 2013 17:03:16 -0000 Message-ID: <20130708170316.14364.80442@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12251/ X-Sender: "bharat kumar" References: <20130704020958.26284.58960@reviews.apache.org> In-Reply-To: <20130704020958.26284.58960@reviews.apache.org> Reply-To: "bharat kumar" --===============5422374522448821056== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22836 ----------------------------------------------------------- server/src/com/cloud/configuration/ConfigurationManagerImpl.java Not calling the Transaction start here. i broke them into smaller transactions. Also not holing the transaction while sending the command to the backend. - bharat kumar On July 4, 2013, 2:09 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 2:09 a.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > ----- > > api/src/com/cloud/network/Network.java a06208b > api/src/com/cloud/network/NetworkService.java 405cecd > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > server/src/com/cloud/network/NetworkManagerImpl.java 708c03d > server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde > server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 > server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f > server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > ------- > > > Thanks, > > bharat kumar > > --===============5422374522448821056==--