Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF4EE10F94 for ; Wed, 3 Jul 2013 16:15:15 +0000 (UTC) Received: (qmail 55165 invoked by uid 500); 3 Jul 2013 16:15:15 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 55039 invoked by uid 500); 3 Jul 2013 16:15:15 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 55030 invoked by uid 500); 3 Jul 2013 16:15:15 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 55021 invoked by uid 99); 3 Jul 2013 16:15:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2013 16:15:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 11BE31CDB35; Wed, 3 Jul 2013 16:15:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7364966428025401585==" MIME-Version: 1.0 Subject: Re: Review Request 12243: CLOUDSTACK-3184: updateVirtualMachine api gives java NPE. From: "ASF Subversion and Git Services" To: "Prasanna Santhanam" , "Devdeep Singh" Cc: "cloudstack" , "Sanjay Tripathi" , "ASF Subversion and Git Services" Date: Wed, 03 Jul 2013 16:15:05 -0000 Message-ID: <20130703161505.26284.63851@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12243/ X-Sender: "ASF Subversion and Git Services" References: <20130703112123.26202.33498@reviews.apache.org> In-Reply-To: <20130703112123.26202.33498@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============7364966428025401585== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12243/#review22723 ----------------------------------------------------------- Commit 614d42dda26f4b1f688f65f597116b2bb5b3d5a7 in branch refs/heads/4.2 from Prasanna Santhanam [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=614d42d ] CLOUDSTACK-3184: integration test for the updateVirtualMachine updateVirutalMachine fails if no args are passed. this test also further verifies that the displayname is changed when vm is started up successfully. Signed-off-by: Prasanna Santhanam (cherry picked from commit 9f0c9ee20c1a65d427702a330798512e7297e322) - ASF Subversion and Git Services On July 3, 2013, 11:21 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12243/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 11:21 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3184 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3184: updateVirtualMachine api gives java NPE. > > This bug is not reproducible from CloudStack UI. Steps to reproduce this bug: > > 1. Deploy a VM without passing any parameters in Name and Description (last step in deploy VM wizard). > 2. Stop this VM. > 3. Fire updateVIrtualMachine API without passing "displayName" parameter, you'll see NPE in MS logs. Do not try with UI because UI will pass displayName paramter with blank value. > > There isn't any null check for displayName parameter and it is null because initially it was not set during the VM deployment and afterwards we are not passing displayName paramter in the API. > > So added null check for displayName in if condition. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java a59fa5b > > Diff: https://reviews.apache.org/r/12243/diff/ > > > Testing > ------- > > Same as Steps mentioned in the description. > > > Thanks, > > Sanjay Tripathi > > --===============7364966428025401585==--