Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D100D10D5E for ; Mon, 1 Jul 2013 21:24:59 +0000 (UTC) Received: (qmail 18522 invoked by uid 500); 1 Jul 2013 21:24:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 18442 invoked by uid 500); 1 Jul 2013 21:24:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 18412 invoked by uid 500); 1 Jul 2013 21:24:50 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 18393 invoked by uid 99); 1 Jul 2013 21:24:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jul 2013 21:24:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 998431CD5F1; Mon, 1 Jul 2013 21:24:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3014257551665427551==" MIME-Version: 1.0 Subject: Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state. From: "ASF Subversion and Git Services" To: "Prasanna Santhanam" , "Abhinandan Prateek" , "Devdeep Singh" Cc: "cloudstack" , "Sanjay Tripathi" , "ASF Subversion and Git Services" Date: Mon, 01 Jul 2013 21:24:41 -0000 Message-ID: <20130701212441.26284.2510@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11670/ X-Sender: "ASF Subversion and Git Services" References: <20130701091900.26202.29531@reviews.apache.org> In-Reply-To: <20130701091900.26202.29531@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============3014257551665427551== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11670/#review22625 ----------------------------------------------------------- Commit ffd5f1a777ac9af5b65b1fcd357684d7dafcce87 in branch refs/heads/vmsync from Sanjay Tripathi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ffd5f1a ] CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state. Signed-off-by: Prasanna Santhanam - ASF Subversion and Git Services On July 1, 2013, 9:18 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11670/ > ----------------------------------------------------------- > > (Updated July 1, 2013, 9:18 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-2288 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeManagerImpl.java a293da5 > > Diff: https://reviews.apache.org/r/11670/diff/ > > > Testing > ------- > > Tests: > 1. In CS setup, put all primary storage in maintenance mode. > 2. Create a volume from snapshot. > > Verified the fix locally. > > > Thanks, > > Sanjay Tripathi > > --===============3014257551665427551==--