Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6179990032927250413=="
MIME-Version: 1.0
Subject: Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with
 Enabling/Clearing
 the Maintenance State of the Storage
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Ram Ganesh" <ram.ganesh@citrix.com>,
 "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "edison su" <edison.su@citrix.com>, "Alex Huang" <alex.huang@citrix.com>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
Date: Mon, 01 Jul 2013 17:18:20 -0000
Message-ID: <20130701171820.26284.39681@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20130628091832.23542.78937@reviews.apache.org>
In-Reply-To: <20130628091832.23542.78937@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============6179990032927250413==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22612
-----------------------------------------------------------


Commit 160b493285f6c72e1e93509dfd470c4bd7da7945 in branch refs/heads/4.2 from Rajesh Battala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=160b493 ]

CLOUDSTACK-2571 Zone Wide Primary Storage blocker issues while Enabling in Maintenance State

Signed-off-by: Edison Su <sudison@gmail.com>


- ASF Subversion and Git Services


On June 28, 2013, 9:18 a.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 9:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, handled the case for ZONE wide scope of storage. 
>    if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the ZONE wide primary storage.
> 
> 
> Diffs
> -----
> 
>   engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 99b7b9c 
>   engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ============= 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's happening and successfully kept the storage in maintenance mode. Verified DB status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the storage, Storage got deleted successfuly. Verify the hosts,  Storage got unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the storage in both clusters is successful.
> kvm specific:
> ============
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===================
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


--===============6179990032927250413==--