cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <min.c...@citrix.com>
Subject Re: help submitting to review board.
Date Tue, 30 Jul 2013 00:42:14 GMT
The person who reviewed and approved should commit the patch for you.

Thanks
-min

On 7/29/13 5:40 PM, "Thomas O'Dowd" <tpodowd@cloudian.com> wrote:

>Hi all,
>
>I'm wondering what the next steps on this[1] review is. I think someone
>needs to merge the patch in before I close but I'm not sure what the
>flow is. Maybe I need to close as submitted first? Can someone advise?
>
>Thanks,
>
>Tom.
>
>[1] https://reviews.apache.org/r/12963/
>
>On Fri, 2013-07-26 at 23:31 +0900, Thomas O'Dowd wrote:
>> Hi John,
>> 
>> 
>> https://reviews.apache.org/r/12963/
>> 
>> Tom. 
>> 
>> On Jul 26, 2013, at 23:20, John Burwell <jburwell@basho.com> wrote:
>> 
>> 
>> > Thomas,
>> > 
>> > What is the link to your review request?
>> > 
>> > Thanks,
>> > -John
>> > 
>> > On Jul 26, 2013, at 5:10 AM, Thomas O'Dowd <tpodowd@cloudian.com>
>> > wrote:
>> > 
>> > > That worked a charm! Thanks. I also *blush* just re-read the
>> > > instructions on this page:
>> > > http://cloudstack.apache.org/develop/non-committer.html
>> > > 
>> > > Thanks again.
>> > > 
>> > > Tom.
>> > > 
>> > > On Fri, 2013-07-26 at 09:06 +0000, Rajesh Battala wrote:
>> > > > In the groups, use "cloudstack"
>> > > > This should be enough to create the request.
>> > > > 
>> > > > Thanks
>> > > > Rajesh Battala
>> > > > 
>> > > > > -----Original Message-----
>> > > > > From: Thomas O'Dowd [mailto:tpodowd@cloudian.com]
>> > > > > Sent: Friday, July 26, 2013 2:34 PM
>> > > > > To: Cloudstack DEV
>> > > > > Subject: help submitting to review board.
>> > > > > 
>> > > > > I'm trying to submit my first patch to review board... however
>> > > > > it says I need
>> > > > > at least one reviewer or group. I can't seem to add anything
>> > > > > under
>> > > > > Reviewers. For Groups, what should I add? The patch is against
>> > > > > the
>> > > > > ConfigurationManager.
>> > > > > 
>> > > > > Thanks!
>> > > > > 
>> > > > > Tom.
>> > > > > --
>> > > > > Cloudian KK - http://www.cloudian.com/get-started.html
>> > > > > Fancy 100TB of full featured S3 Storage?
>> > > > > Checkout the Cloudian® Community Edition!
>> > > > 
>> > > 
>> > > -- 
>> > > Cloudian KK - http://www.cloudian.com/get-started.html
>> > > Fancy 100TB of full featured S3 Storage?
>> > > Checkout the Cloudian® Community Edition!
>> > > 
>> > 
>> > 
>
>-- 
>Cloudian KK - http://www.cloudian.com/get-started.html
>Fancy 100TB of full featured S3 Storage?
>Checkout the Cloudian® Community Edition!
>


Mime
View raw message