cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pranav Saxena <psb...@gmail.com>
Subject Re: Git Push Summary
Date Thu, 18 Jul 2013 06:47:08 GMT
Hey Isaac ,

I verified your code changes in your private asf branch . The code changes
look good to me. I am assuming that it would work fine for the following
cases -
1) Dedication is a success , addition of resource is a success
2) Dedication is a failure , addition of resource is still a success
3) Dedication is a failure , addition is also a failure

 - All 3 cases should have notification displayed for each of the API calls
getting triggered ( which I believe would be there after your code changes)
 - Also you could provide a "setInterval" waiting time function of say 2-3
seconds between two successive notifications.

One thing which I realized after looking at your code changes is that you
would have to bear the pain of resolving the merge conflicts when you merge
your branch with master. Since your code modifications/additions have been
done on the already existing code , I am pretty sure you would have to take
care of these conflicts. Since the changes aren't that huge, you could
manually copy them to the master branch or replace the entire system.js
file in your branch in the master assuming you forked your branch out of
master and there haven't been other changes in system.js file . First
option is a safer approach though !!

Thanks,
Pranav


On Thu, Jul 18, 2013 at 8:18 AM, Isaac Chiang <isaacchiang@gmail.com> wrote:

> Hi Pranav:
>              I just pushed part of modified code in to the branch.
> Please have a look if the commit fix the issue as expected.
>
> Thanks,
>
> Regards
>
>
> ---------- Forwarded message ----------
> From: Pranav Saxena <psbits@gmail.com>
> Date: Tue, Jul 16, 2013 at 4:52 PM
> Subject: Re: Git Push Summary
> To: dev@cloudstack.apache.org, jessica.wang@citrix.com,
> sonny.chhen@citrix.com
> Cc: commits@cloudstack.apache.org
>
>
> Thanks Isaac for creating this branch. I'll keep an eye on the commits you
> make your here . Once the code for handling nested query API calls are
> ready , you can merge it into master.
>
> @Jessica - I have had conversations with Isaac and he is in the process of
> re-factoring the code for dedicated resources to handle the nested query
> API calls . You could review it once as well when he sends out a request
> for merge . It should not be a big change though !
>
> Thanks,
> Pranav
>
>
> On Tue, Jul 16, 2013 at 2:00 PM, <isaacchiang@apache.org> wrote:
>
> > Updated Branches:
> >   refs/heads/ui-dedicatedresources-refactoring [created] 22ddc3fa0
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message