cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dharmesh Kakadia <dhkaka...@gmail.com>
Subject Re: [CLOUDSTACK-212] [Review Request and Test]
Date Wed, 17 Jul 2013 10:49:25 GMT
sure. You tried the files attached on reviewboard ? 0001*, 0002* and 0003*
?


On Wed, Jul 17, 2013 at 4:04 PM, Sebastien Goasguen <runseb@gmail.com>wrote:

>
> On Jul 17, 2013, at 6:13 AM, Dharmesh Kakadia <dhkakadia@gmail.com> wrote:
>
> > Can someone commit the changes to namespacechanges branch ?
> >
>
> Dharmesh, I tried this morning but there were several errors. I have not
> had time to look deeper into it.
>
> Maybe Chip and John will get to it faster than I can.
>
> -sebastien
>
> > Thanks,
> > Dharmesh
> >
> >
> > On Tue, Jul 16, 2013 at 10:09 AM, Dharmesh Kakadia <dhkakadia@gmail.com
> >wrote:
> >
> >> juberwell and chip
> >>
> >> Sorry. I forgot to mention that this patches are for namespace branch.
> Is
> >> this the right way to push changes into feature branch for
> non-committers ?
> >>
> >> Thanks,
> >> Dharmesh
> >>
> >>
> >> On Tue, Jul 16, 2013 at 2:37 AM, John Burwell <jburwell@basho.com>
> wrote:
> >>
> >>> Chip,
> >>>
> >>> I apologize for my lack clarity.  I am only -1 for master merge until
> the
> >>> community has reviewed the changes and come to consensus on landing the
> >>> change.  I am +1 to push the changes into a dedicated feature branch
> within
> >>> the ASF repo..
> >>>
> >>> Thanks,
> >>> -John
> >>>
> >>> On Jul 15, 2013, at 4:34 PM, Chip Childers <chip.childers@sungard.com>
> >>> wrote:
> >>>
> >>>> On Mon, Jul 15, 2013 at 04:30:53PM -0400, John Burwell wrote:
> >>>>> Dharnesh,
> >>>>>
> >>>>> I am placing a pre-emptive -1 on this patch merge because I don't
> feel
> >>> adequate community awareness/coordination regarding the impact of this
> >>> change.  In particular, I want to make the sure the timing is
> appropriate
> >>> since we doing a lot of master->4.2 merges at the moment.  This patch
> will
> >>> increase the difficulty of these merges.  Please email send a [MERGE]
> email
> >>> (e.g. subject "[MERGE] Global Conversion from com.cloud.* to
> org.apache.*")
> >>> to the list explaining the scope of the change in detail and the
> potential
> >>> impacts.  Once the community arrives at a consensus on timing and
> impacts,
> >>> I will withdraw my -1.
> >>>>>
> >>>>
> >>>> AFAIK, the idea was to get them into the repo, under the
> >>>> namespacechanges branch.  After they are in, that's a good place to
go
> >>>> through the conflict resolution, etc...  and then do the process you
> are
> >>>> suggesting.
> >>>>
> >>>>> Thanks,
> >>>>> -John
> >>>>>
> >>>>> On Jul 15, 2013, at 4:20 PM, Dharmesh Kakadia <dhkakadia@gmail.com>
> >>> wrote:
> >>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> I have completed the namespace changes to org.apache. A single
patch
> >>> was leaving some deleted files behind. I tried to figure out the
> problem
> >>> for a day, but didn't get any issue. So I have created 3 different
> patches
> >>> and uploaded to the reviewboard (https://reviews.apache.org/r/12198/).
> >>>>>>
> >>>>>> I have updated the scripts as well as docs(mostly). I have build
it
> >>> with all testcases and successfully ran management server.
> >>>>>>
> >>>>>> I will submit whitespace changes patch soon. In mean time if
others
> >>> can test other scripts, packaging, specific extension etc. Is that
> required
> >>> or full test run is good enough ? we can merge changes on 20th
> accordingly.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Dharmesh
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>
> >>>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message