cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus Sorensen <shadow...@gmail.com>
Subject Re: Review Request 12775: Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command
Date Fri, 26 Jul 2013 21:52:19 GMT
I did, I'll close the review request


On Fri, Jul 26, 2013 at 3:39 PM, Animesh Chaturvedi <
Animesh.Chaturvedi@citrix.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12775/
>
> On July 24th, 2013, 2:08 p.m. UTC, *Wido den Hollander* wrote:
>
> So it took me some time to get around reviewing this, but it seems fine to me.
>
> I patched a running 4.1 cluster with this and works like a charm. DHCP entries were loaded
at the same rate, but the user metadata went a lot faster.
>
>  Wido did you commit the patch? Is so can this be closed out
>
>
> - Animesh
>
> On July 19th, 2013, 9:20 p.m. UTC, Marcus Sorensen wrote:
>   Review request for cloudstack, ilya musayev and Wido den Hollander.
> By Marcus Sorensen.
>
> *Updated July 19, 2013, 9:20 p.m.*
>  *Bugs: * cloudstack-3163
>  *Repository: * cloudstack-git
> Description
>
> Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command.
>
>   Testing
>
> Tested on 4.2 advanced zone, as well as a version against 4.1 (patch applies with fuzz)
since that's what we happen to be using at the moment. Started VM, then ran 'curl http://10.1.1.1/latest/instance-id',
then ran updateVirtualMachine, setting userdata, and pulled it on the guest via 'curl http://10.1.1.1/latest/user-data'.
>
>   Diffs
>
>    - core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
>    (0b26220)
>    - patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py
>    (PRE-CREATION)
>    - scripts/network/domr/vm_data.sh (c861723)
>
> View Diff <https://reviews.apache.org/r/12775/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message