cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: [DISCUSS] maven dependencies...
Date Tue, 30 Jul 2013 15:11:40 GMT
On Tue, Jul 30, 2013 at 10:22 AM, Alex Huang <Alex.Huang@citrix.com> wrote:

> Chip and Donal,
>
> I should have replied to this earlier.  I changed from a logging category
> of [cloud.vm.VirtualMachineManagerImpl] to
> [c.c.v.VirtualMachineManagerImpl].  It's shorter and really no one looks at
> the package any more with editors that can open any file from any package
> but every so often you need it and having the package abbreviation comes in
> handy.  To do that I changed from %{c3} to %{c1.} but it required the use
> of EnhancedPatternLayout.
>
> What I failed to notice (because the startup log rolls by so fast) is that
> some of the appenders are not using EnhancedPatternLayout.
>
> I've already put in a fix after Donal's email to put the ones that are
> using PatternLayout to go back to the old %{c3}.  They're specific to
> syslog and snmp so I didn't want to screw up anything in those
> implementations.
>
> I will revert Chip's commit that changed all the rest of them to %{c1}
> unless we rather not have the package abbreviations.
>
>
Good clarification.  Revert away.


> --Alex
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Tuesday, July 30, 2013 6:05 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] maven dependencies...
> >
> > On Mon, Jul 29, 2013 at 08:40:44PM +0000, Donal Lafferty wrote:
> > > Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?
> > >
> > > It looks like it was updated in the refactor.
> > >
> > > AFAIK, in '<param name="ConversionPattern" value="%-5p [%c{1.}]
> > (%t:%x) %m%n"/>', {1.} should be {1}.
> > >
> > > See "Conversion Character" chart under
> >
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayou
> > t.html
> > >
> > > There's a lot of paper work for me to make the update :(
> > >
> > > DL
> >
> > Done!
> >
> > commit 4c729e7
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message