cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request 12658: Corrected typos in log messages
Date Sat, 27 Jul 2013 18:52:26 GMT
The submitter should close it out once the patch is approved and checked-in. The reviewer cannot
close the patch unless they have admin privileges. If you want admin privileges you can open
a ticket with Infra.

> -----Original Message-----
> From: Wido den Hollander [mailto:wido@widodh.nl]
> Sent: Saturday, July 27, 2013 11:16 AM
> To: Animesh Chaturvedi
> Cc: cloudstack; Rene Diepstraten
> Subject: Re: Review Request 12658: Corrected typos in log messages
> 
> On 07/26/2013 11:41 PM, Animesh Chaturvedi wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/12658/
> >
> >
> >     On July 18th, 2013, 9:48 a.m. UTC, *Wido den Hollander* wrote:
> >
> >         Ship It!
> >
> > Wido did you commit the patch? If so this needs to be closed out
> >
> >
> 
> So how do I close it? I don't see an option for that. Could it be that I
> don't have the correct permissions to do so?
> 
> Wido
> 
> > - Animesh
> >
> >
> > On July 18th, 2013, 4:07 p.m. UTC, Rene Diepstraten wrote:
> >
> > Review request for cloudstack and Wido den Hollander.
> > By Rene Diepstraten.
> >
> > /Updated July 18, 2013, 4:07 p.m./
> >
> > *Repository: * cloudstack-git
> >
> >
> >   Description
> >
> > Corrected typos in log messages
> >
> >
> >   Testing
> >
> > These are only log messages and should not change how the code works.
> >
> >
> >   Diffs
> >
> >   * scripts/vm/network/security_group.py (044747a)
> >
> > View Diff <https://reviews.apache.org/r/12658/diff/>
> >
Mime
View raw message