cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <>
Subject Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
Date Wed, 31 Jul 2013 15:07:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 31, 2013, 3:07 p.m.)

Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


changed the function getvnets to use coma instead of semicolon.

Bugs: Cloudstack-3753

Repository: cloudstack-git

Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

Diffs (updated)

  api/src/com/cloud/network/ 59ccdbf 
  api/src/org/apache/cloudstack/api/command/admin/network/ 333564e

  engine/schema/src/com/cloud/dc/dao/ e2e6b79 
  engine/schema/src/com/cloud/dc/dao/ ced2982 
  engine/schema/src/com/cloud/network/dao/ f68eee1 
  server/src/com/cloud/network/ f1f71ca 
  server/test/com/cloud/network/ 4577d0a 
  server/test/com/cloud/network/ e3fc36a 
  server/test/com/cloud/vpc/ fd61bc6 



Tested on master.
removed the removevlan parameter.
vlan parameter can be used for both addition and removal of valns.
instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to
the vlan ranges missing in the input and present in the db (not allocated) will be removed.


bharat kumar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message