cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.
Date Wed, 31 Jul 2013 04:33:56 GMT


> On July 31, 2013, 4:31 a.m., Abhinandan Prateek wrote:
> > Ship It!

Failed on master:

error: patch failed: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java:433
error: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java: patch does not apply
Patch failed at 0001 Cloudstack-2997 Make Haproxy maxconn configurable.
The copy of the patch that failed is found in:
   /Users/agneya2001/citrix/asf/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


- Abhinandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13058/#review24318
-----------------------------------------------------------


On July 30, 2013, 10:52 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13058/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 10:52 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2997
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2997
> 
> cloud not update the concurrent_connections parameter of networkoffering because of some
dao dependency.
> 
> The update was not happening because of choosing a VO variable name having a underscore.
 
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java 6b35d7b 
>   engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a 
>   server/src/com/cloud/api/ApiResponseHelper.java e331bef 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 
> 
> Diff: https://reviews.apache.org/r/13058/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message