cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk" <alena.prokharc...@citrix.com>
Subject Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
Date Tue, 30 Jul 2013 21:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24293
-----------------------------------------------------------


Bharat, applied the patch on the latest 4.2. Created a physical network with vnet range:

mysql> select vnet from physical_network;
+-----------+
| vnet      |
+-----------+
| 2000-2079 |
+-----------+

And updatePhysicalNetwork failed to update it with the new vlan range:

http://localhost:8096/?command=updatePhysicalNetwork&id=200&vlan=2001-2010,2012-2013

ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-9:job-11 = [ 58ff063c-1ad6-45d8-89dd-d39dec291c1c
]) Unexpected exception while executing org.apache.cloudstack.api.command.admin.network.UpdatePhysicalNetworkCmd
java.lang.NumberFormatException: For input string: "2000,2011"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
	at java.lang.Integer.parseInt(Integer.java:458)
	at java.lang.Integer.parseInt(Integer.java:499)
	at com.cloud.network.NetworkServiceImpl.getVnetsToremove(NetworkServiceImpl.java:2751)
	at com.cloud.network.NetworkServiceImpl.addOrRemoveVnets(NetworkServiceImpl.java:2596)
	at com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
	at com.cloud.network.NetworkServiceImpl.updatePhysicalNetwork(NetworkServiceImpl.java:2575)
	at com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
	at org.apache.cloudstack.api.command.admin.network.UpdatePhysicalNetworkCmd.execute(UpdatePhysicalNetworkCmd.java:98)
	at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
	at com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
	at java.lang.Thread.run(Thread.java:680)
ERROR [cloud.api.ApiServer] (ApiServer-1:) invalid request, no command sent


Could you please fix it, as well as give it more QA on 4.2?

- Alena Prokharchyk


On July 30, 2013, 8:53 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 8:53 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" per command
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges that he wants
to keep.
> the vlan ranges missing in the input and present in the db (not allocated) will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message