cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mice xia" <mice_...@tcloudcomputing.com>
Subject Re: Review Request 13047: VMSnapshot chainSize check
Date Tue, 30 Jul 2013 01:49:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13047/#review24200
-----------------------------------------------------------


the chainSize for a volume is the total size of all nodes, not a single snapshot volume size,
so no matter current snapshot is memoryDisk or Disk,  all memory image associated with this
vm should be considered

- mice xia


On July 30, 2013, 12:38 a.m., Amogh Vasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13047/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 12:38 a.m.)
> 
> 
> Review request for cloudstack and mice xia.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3591
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add check to ensure chainSize adds memory size to ROOT volume only when VMSnapshot Type
is DiskAndMemory
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
10b6de9 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
fa7f2ec 
> 
> Diff: https://reviews.apache.org/r/13047/diff/
> 
> 
> Testing
> -------
> 
> Local environment
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message