cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 12913: Fix map based APIs in CloudMonkey
Date Sun, 28 Jul 2013 11:06:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12913/#review24057
-----------------------------------------------------------


Thanks, it was applied on the new cloudmonkey/master repo;
commit 924554fa2507818b7d77144c70e6bf5387b33175
Author:     Carson Anderson <carson@betterservers.com>
AuthorDate: Thu Jul 25 15:50:14 2013 -0600
Commit:     Rohit Yadav <bhaisaab@apache.org>
CommitDate: Sun Jul 28 16:15:20 2013 +0530


- Rohit Yadav


On July 25, 2013, 4:52 a.m., Carson Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12913/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:52 a.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Bugs: CLOUDSTACK-3787
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CM does not detect required tags if they are passed as a map. When creating resource
tags for example. The tags[0].key and tags[0].value weren't counted for the "tags" parameter
and CM would give a "missing required parameter" error.
> 
> 
> Diffs
> -----
> 
>   tools/cli/cloudmonkey/cloudmonkey.py 13f54ad 
> 
> Diff: https://reviews.apache.org/r/12913/diff/
> 
> 
> Testing
> -------
> 
> Tested by adding/removing resourceTags
> 
> 
> Thanks,
> 
> Carson Anderson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message