cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jenkins Cloudstack.org" <h...@apache.org>
Subject Re: Review Request 12985: CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM
Date Sat, 27 Jul 2013 01:13:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12985/#review24003
-----------------------------------------------------------


Review 12985 PASSED the build test
The url of build cloudstack-master-with-patch #57 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/57/

- Jenkins Cloudstack.org


On July 27, 2013, 12:25 a.m., Toshiaki Hatano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12985/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 12:25 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo
Trippaers, and Sheng Yang.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3682
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack-management suddenly start generating broadcastUri in 'vlan:XXXX' style instead
of 'vlan://XXXX' style.
> That cause issue in KVM-agent VifDrivers (both Bridge and OVS), since they cannot purse
different style Uri.
> 
> For the compatibility to older version, CloudStack-management should generate 'vlan://XXXX'
style BroadcastUri.
> 
> Change the URI creation way in 2 method below to make sure they generate 'scheme://host'
style BroadcastUri.
>     - com.cloud.network.Networks.IsolationType.toUri(T)
>     - com.cloud.network.Networks.BroadcastDomainType.toUri(T)
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
195cf40 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 7038d7e

>   server/src/com/cloud/network/guru/PublicNetworkGuru.java 8beb42e 
> 
> Diff: https://reviews.apache.org/r/12985/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, advanced zone with a KVM hypervisor. 
> 
> 
> Thanks,
> 
> Toshiaki Hatano
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message