cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <Animesh.Chaturv...@citrix.com>
Subject Re: Review Request 12963: Fix some simple typos in ConfigurationManager
Date Fri, 26 Jul 2013 21:44:29 GMT


> On July 26, 2013, 2:33 p.m., John Burwell wrote:
> > Looks clean to me.  Good cleanups.

Can you submit the patch and help close the review?


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12963/#review23950
-----------------------------------------------------------


On July 26, 2013, 9:07 a.m., Thomas O'Dowd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12963/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 9:07 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Simple text only fixes to update some typos I noticed in log messages when testing 4.2.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 6c32c55 
> 
> Diff: https://reviews.apache.org/r/12963/diff/
> 
> 
> Testing
> -------
> 
> Although this patch is against master, I cherry picked it locally to test against 4.2
and did a clean compile. I was able to see the updated message for "in stead" but I didn't
check the other messages.
> 
> 
> Thanks,
> 
> Thomas O'Dowd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message