cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <Animesh.Chaturv...@citrix.com>
Subject Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
Date Fri, 26 Jul 2013 21:43:36 GMT


> On July 18, 2013, 11:49 a.m., Wido den Hollander wrote:
> > Seems good to me. This isn't a major change

Can you commit the patch and help close the review


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/#review23374
-----------------------------------------------------------


On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12660/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 3:57 p.m.)
> 
> 
> Review request for cloudstack and Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Replaced multiple grep/awk/head commands by one awk.
> 
> 
> Diffs
> -----
> 
>   scripts/vm/network/security_group.py c1c87da 
> 
> Diff: https://reviews.apache.org/r/12660/diff/
> 
> 
> Testing
> -------
> 
> Tested output. Not able to test using cloudstack function execute() or real ebtables
output.
> 
> 
> Thanks,
> 
> Rene Diepstraten
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message