cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 12948: Affinity Groups: Adding new test cases
Date Fri, 26 Jul 2013 17:04:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/#review23954
-----------------------------------------------------------



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47788>

    This will fail as delete is not a @classmethod no affinity groups anymore. use aff_group.delete(self.apiclient)
instead



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47789>

    I've separated the create_aff_grp() calls to actually return the aff_grp instead of append
to a list in other tests. 
    
    Ideally I'd like to remove such utility methods within the tests altogether since they
don't really provide clarity to the test scenario being executed. But that refactoring can
be done once the tests are passed.



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47790>

    Do we need to wait here? Can we just send for delete and exit so GC can take care?



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47791>

    use debug statements. print will not show in the testrunner



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47792>

    The tag 'multihost' is reserved for situations where the test requires multiple hosts
to be executed successfully. Can you please remove that tag from the tests?



test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47793>

    wait should not be required.


- Prasanna Santhanam


On July 26, 2013, 9:43 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12948/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 9:43 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding new test cases for affinity groups
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
> 
> Diff: https://reviews.apache.org/r/12948/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message