cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.
Date Fri, 26 Jul 2013 12:42:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12968/
-----------------------------------------------------------

Review request for cloudstack and Min Chen.


Bugs: 3686


Repository: cloudstack-git


Description
-------

Registering a template does not generate a usage event.
The process should generate a usage event when the template is 100% downloaded.
Added a new usage event that has virtual_size also as a parameter.


Diffs
-----

  engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
  engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef 
  server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade 

Diff: https://reviews.apache.org/r/12968/diff/


Testing
-------

Now usage_event table is getting updated with the new usage_event.

 select * from usage_event where id = 23;
+----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+
| id | type            | account_id | created             | zone_id | resource_id | resource_name
| offering_id | template_id | size     | resource_type | processed | virtual_size |
+----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+
| 23 | TEMPLATE.CREATE |          2 | 2013-07-26 12:04:29 |       0 |         215 | r8   
        |        NULL |        NULL | 16777728 | NULL          |         0 |     16777216
|
+----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+


Build passed.
Patch applies cleanly.


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message