cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Shilamkar" <gir...@clogeny.com>
Subject Re: Review Request 12962: CLOUDSTACK-3594: Fix params of AffinityGroup.delete API
Date Fri, 26 Jul 2013 10:55:57 GMT


> On July 26, 2013, 8:21 a.m., Prasanna Santhanam wrote:
> > I've changed the library method to only accept delete by id last night. Can you
reuse that? We need to keep the delete operations consistent across the integration library.
> > If a custom delete is required, then that can be handled within the test.
> > 
> > So this test will fail with the latest marvin

I think most of the tests will fail in that case. I will fix them.


- Girish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12962/#review23918
-----------------------------------------------------------


On July 26, 2013, 7:42 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12962/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 7:42 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3594: Fix params of AffinityGroup.delete API
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_affinity_groups.py 3f257c3 
> 
> Diff: https://reviews.apache.org/r/12962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message