cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12838: CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools are not in the right state.
Date Fri, 26 Jul 2013 10:21:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12838/#review23930
-----------------------------------------------------------


Commit f4eab352e04bdafc5307bd7aa21a4433c58ba871 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f4eab35 ]

CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools are not in the right
state.

This issue is reporducible if user adds a primary storage and quickly fires
listStoragePool API command without waiting for the responce of previous
createStoragePool API command. So during this period
(before receiving createStoragePool API resonce), the primary srorage is in
initialized status and the "scope" of storage is not set.


- ASF Subversion and Git Services


On July 23, 2013, 5:30 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12838/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 5:30 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3488
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>     CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools are not
in the right state.
> 
>     This issue is reporducible if user adds a primary storage and quickly fires
>     listStoragePool API command without waiting for the responce of previous
>     createStoragePool API command. So during this period
>     (before receiving createStoragePool API resonce), the primary srorage is in
>     initialized status and the "scope" of storage is not set.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 503a563 
> 
> Diff: https://reviews.apache.org/r/12838/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 1. Add a primary storage.
> 2. Quickly fire listStoragePool API command.
> 
> Verified that listStoragePool API command is working properly without hitting any NPE.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message