cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 12934: Tests for egress firewall rules for advance zone
Date Fri, 26 Jul 2013 09:12:27 GMT


> On July 26, 2013, 8:46 a.m., Sheng Yang wrote:
> > test/integration/component/test_egress_fw_rules.py, line 253
> > <https://reviews.apache.org/r/12934/diff/2/?file=328044#file328044line253>
> >
> >     I think we already have alike mechanism for executing inside user VM? Check
get_ssh_client. If it doesn't fit, we need some generic mechanism rather than one method for
one test case.

Yes, that method works when VM is created with mode=advance. Here we don't want to create
PF rule and setup public ip for a VM. we just want to test the egress rule and policy. In
this case we have to take hopes to Hypervisor Host-> Router-> VM instance to reach out
VM for checking the public network access.


> On July 26, 2013, 8:46 a.m., Sheng Yang wrote:
> > test/integration/component/test_egress_fw_rules.py, line 619
> > <https://reviews.apache.org/r/12934/diff/2/?file=328044#file328044line619>
> >
> >     You need to wait a while (e.g. 60 seconds) for mgmt server complete the updating
of RvR status.

VirtualMachine.Create() waits till VM is up and VM comes up only after Network is up leading
RVR up. no need to put a wait here.


> On July 26, 2013, 8:46 a.m., Sheng Yang wrote:
> > test/integration/component/test_egress_fw_rules.py, line 183
> > <https://reviews.apache.org/r/12934/diff/2/?file=328044#file328044line183>
> >
> >     Missing tearDown()

No, teamDown is not missing. it's there on line 352.


> On July 26, 2013, 8:46 a.m., Sheng Yang wrote:
> > test/integration/component/test_egress_fw_rules.py, line 166
> > <https://reviews.apache.org/r/12934/diff/2/?file=328044#file328044line166>
> >
> >     Missing clean up for account and domain.

No, cleanup for account and domain is in teamDownClass.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review23920
-----------------------------------------------------------


On July 26, 2013, 6:27 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:27 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message