cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 12934: Tests for egress firewall rules for advance zone
Date Fri, 26 Jul 2013 09:05:18 GMT


> On July 25, 2013, 6:25 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 99
> > <https://reviews.apache.org/r/12934/diff/1/?file=327722#file327722line99>
> >
> >     Please check the below configurable option for egress firewall rules.
> >     
> >     https://issues.apache.org/jira/browse/CLOUDSTACK-1578
> >     
> >     For the default offering egress is block.
> >     For the newly creating offering the egress default is allow and block the traffic
for the created rules.
> >     
> >     So update the test cases for the above

Added Test for this use case.


> On July 25, 2013, 6:25 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 100
> > <https://reviews.apache.org/r/12934/diff/1/?file=327722#file327722line100>
> >
> >     create two network offering one with 'egress_policy'= true and other is 'egress_policy'=
false
> >     Add the test cases for both

Updated the service data to cover egress policy.


> On July 25, 2013, 6:25 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 106
> > <https://reviews.apache.org/r/12934/diff/1/?file=327722#file327722line106>
> >
> >     Add 'egress_policy' entry in the network offering.

Done


> On July 25, 2013, 6:25 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 121
> > <https://reviews.apache.org/r/12934/diff/1/?file=327722#file327722line121>
> >
> >     1. create a network offering without redundant router
> >     2. You can have another offering/test case with redundant router

Done


> On July 25, 2013, 6:25 a.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 363
> > <https://reviews.apache.org/r/12934/diff/1/?file=327722#file327722line363>
> >
> >     Please refer https://cwiki.apache.org/confluence/display/CLOUDSTACK/Egress+firewall+rules+-+Ability+to+change+the+default

> >     
> >     update the test case accordingly

Done


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review23820
-----------------------------------------------------------


On July 26, 2013, 6:27 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:27 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message