cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
Date Fri, 26 Jul 2013 08:45:34 GMT


> On July 26, 2013, 6:45 a.m., Nitin Mehta wrote:
> > engine/schema/src/com/cloud/vm/VMInstanceVO.java, line 149
> > <https://reviews.apache.org/r/12937/diff/2/?file=327891#file327891line149>
> >
> >     we need to start showing it in response as well

I have changed the uservm view table to get the value from vm_instance. Please refer to the
change in schema-410to420.sql https://reviews.apache.org/r/12937/diff/#9


> On July 26, 2013, 6:45 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/server/ManagementServerImpl.java, line 3749
> > <https://reviews.apache.org/r/12937/diff/2/?file=327896#file327896line3749>
> >
> >     Will this block KVM upgrade when the system vms are stopped

This is a specific check for xenserver and running system vm. For KVM or other hypervisors
condition will fail in first check itself.


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review23914
-----------------------------------------------------------


On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 8:41 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3779: Support System vm scaling on VMWare
> 
> Marked the system template new system template as dynamicallyScalable
>    - handled upgrade case
>    - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details to support
dynamic scaling of system vm
> 
> This patch depends on previous review request https://reviews.apache.org/r/12759/ . please
review and commit accordingly
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 
>   engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
2cc592d 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd 
>   server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 
>   server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d 
>   setup/db/db/schema-410to420.sql 82ca403 
> 
> Diff: https://reviews.apache.org/r/12937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message