cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
Date Thu, 25 Jul 2013 22:13:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23878
-----------------------------------------------------------


Commit a39de009da8df5080c2273d77f92a9ae75bff8d6 in branch refs/heads/master from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a39de00 ]

CLOUDSTACK-2536: fix the regression introduced by 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f


- ASF Subversion and Git Services


On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 7:19 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2536:  updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor
are redundant(cluster level) 
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters.
Ideally this should get updated using updateConfiguration API, so removing from updateCluster
API
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/resource/ResourceService.java 25298cc 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6

>   api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905

>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd 
>   server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd 
>   server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 
> 
> Diff: https://reviews.apache.org/r/12808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message