cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rene Diepstraten" <m...@renediepstraten.nl>
Subject Review Request 12943: Replaced virsh() by python-libvirt functions
Date Thu, 25 Jul 2013 14:01:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12943/
-----------------------------------------------------------

Review request for cloudstack and Wido den Hollander.


Repository: cloudstack-git


Description
-------

In scripts/vm/network/security_group.py, external calls to virsh are made.
Python has a module python-libvirt which has native libvirt bindings.
This patch replaces the external calls to the virsh command with functions that use the native
python implementation.


Diffs
-----

  debian/control 46dd505 
  packaging/centos63/cloud.spec 61e00bd 
  scripts/vm/network/security_group.py 2ce558f 

Diff: https://reviews.apache.org/r/12943/diff/


Testing
-------

Tested the output of the new functions. This should be the same as the virsh command.


Thanks,

Rene Diepstraten


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message