cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
Date Thu, 25 Jul 2013 07:19:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/
-----------------------------------------------------------

(Updated July 25, 2013, 7:19 a.m.)


Review request for cloudstack, Koushik Das and Nitin Mehta.


Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536


Repository: cloudstack-git


Description
-------

CLOUDSTACK-2536:  updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor
are redundant(cluster level) 
There are two APIs updateCluster and UpdateConfiguration where we can update these parameters.
Ideally this should get updated using updateConfiguration API, so removing from updateCluster
API


Diffs (updated)
-----

  api/src/com/cloud/resource/ResourceService.java 25298cc 
  api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 
  api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6 
  api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd 
  server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd 
  server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 

Diff: https://reviews.apache.org/r/12808/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message