cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Frank Zhang" <frank.zh...@citrix.com>
Subject Re: Review Request 12877: Support HTTP to HTTPS redirect for UCS
Date Wed, 24 Jul 2013 20:46:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12877/#review23782
-----------------------------------------------------------

Ship it!


shipped in both 4.2/master

- Frank Zhang


On July 23, 2013, 7:56 p.m., Amogh Vasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12877/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 7:56 p.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3285
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The patch uses EasySSLProtocolFactory from httpclient.contrib.ssl package.
> The implementation accepts self-signed certificates. This is similar to cloud-plugin-network-cisco-vnmc
's behavior.
> As a part of the patch, the contrib code has been moved to cloud-utils to avoid duplication.
> Since there is no maven published jar for contrib, the source currently has the actual
code instead. This needs to be revisited.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsHttpClient.java 66d2ed2 
>   plugins/network-elements/cisco-vnmc/src/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java
52f0ea6 
>   plugins/network-elements/cisco-vnmc/src/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java
ae9f938 
>   utils/src/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java
PRE-CREATION 
>   utils/src/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/12877/diff/
> 
> 
> Testing
> -------
> 
> Works on local environment + UCS
> cisco-vnmc not tested after refactoring
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message