cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Dietrich" <>
Subject Re: Review Request 12752: Async commands can inject the job id
Date Fri, 19 Jul 2013 17:54:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 19, 2013, 5:54 p.m.)

Review request for cloudstack and Marcus Sorensen.


Thanks for the code change mod Marcus!  (changed the length call to the regex, I verified
in the database this was the exact format being used)

Repository: cloudstack-git


I added "injectedjobid" to the BaseAsyncCmd class as a parameter.
If set, it will allow you to tell Cloudstack what the job id instead of it choosing one.
A basic string length test is done to verify the variable passed in is actually a UUID.
If it is not valid, it is ignored and the job generates it's own.

Diffs (updated)

  api/src/org/apache/cloudstack/api/ 0e6f95d 
  server/src/com/cloud/api/ 95f17af 
  server/src/com/cloud/async/ 41eccb4 
  test/integration/smoke/ 425aeb7 
  tools/marvin/marvin/ 632b8c6 
  tools/marvin/marvin/integration/lib/ 161d03c 



Updated marvin, updated the deploy vm test.  Ran multiple async commands manually, with and
without injectedjobid present, no issues detected.


Ryan Dietrich

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message