cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Duffy" <...@ianduffy.ie>
Subject Re: Review Request 12721: Formatting of CSS and JS files
Date Thu, 18 Jul 2013 16:30:07 GMT


> On July 18, 2013, 4:24 p.m., Pranav Saxena wrote:
> > Changes look good. I don't have an access to my machine from where I could commit
your changes. Hence, request a committer to merge these into all the relevant branches.
> > Thanks !

Okay will leave it as open until a committer merges them.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12721/#review23391
-----------------------------------------------------------


On July 18, 2013, 2:47 p.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12721/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 2:47 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Format CSS and JS files using js-beautifier as discussed on the mailing list.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/accounts.js bad8435 
>   ui/scripts/affinity.js a9c6695 
>   ui/scripts/autoscaler.js 15a9dac 
>   ui/scripts/cloud.core.callbacks.js 6eb7644 
>   ui/scripts/cloudStack.js c0ff7f2 
>   ui/scripts/configuration.js 8bc40d6 
>   ui/scripts/dashboard.js e8ab6c5 
>   ui/scripts/docs.js c8ef0d9 
>   ui/scripts/domains.js 01f4236 
>   ui/scripts/events.js bd50887 
>   ui/scripts/globalSettings.js 1ae73b7 
>   ui/scripts/installWizard.js 46769fa 
>   ui/scripts/instanceWizard.js ff130d3 
>   ui/scripts/instances.js 9b27d93 
>   ui/scripts/lbStickyPolicy.js c0e2bfa 
>   ui/scripts/network.js 95a93bc 
>   ui/scripts/plugins.js 3c5bc0f 
>   ui/scripts/projects.js ea1e6db 
>   ui/scripts/regions.js 4be600f 
>   ui/scripts/sharedFunctions.js a9f833c 
>   ui/scripts/storage.js ad0965a 
>   ui/scripts/system.js 3038a8a 
>   ui/scripts/templates.js dbb0083 
>   ui/scripts/ui-custom/affinity.js 1a23ff7 
>   ui/scripts/ui-custom/autoscaler.js 119b672 
>   ui/scripts/ui-custom/dashboard.js 6d92318 
>   ui/scripts/ui-custom/enableStaticNAT.js 1b2bf7b 
>   ui/scripts/ui-custom/granularSettings.js 02d5c1f 
>   ui/scripts/ui-custom/healthCheck.js 4b42fa7 
>   ui/scripts/ui-custom/installWizard.js c53a642 
>   ui/scripts/ui-custom/instanceWizard.js 31b4baa 
>   ui/scripts/ui-custom/ipRules.js 34b2398 
>   ui/scripts/ui-custom/login.js 0dbbf82 
>   ui/scripts/ui-custom/physicalResources.js 5173172 
>   ui/scripts/ui-custom/pluginListing.js 3dcce98 
>   ui/scripts/ui-custom/projectSelect.js aef49ed 
>   ui/scripts/ui-custom/projects.js f1f9eba 
>   ui/scripts/ui-custom/recurringSnapshots.js 985f369 
>   ui/scripts/ui-custom/regions.js 9fc36f3 
>   ui/scripts/ui-custom/securityRules.js 2e2c9ac 
>   ui/scripts/ui-custom/uploadVolume.js 996d8ac 
>   ui/scripts/ui-custom/vpc.js 4edccf1 
>   ui/scripts/ui-custom/zoneChart.js 5d4e0c0 
>   ui/scripts/ui-custom/zoneFilter.js 9e6a493 
>   ui/scripts/ui-custom/zoneWizard.js 877dbc0 
>   ui/scripts/ui/core.js 18c3363 
>   ui/scripts/ui/dialog.js 7f82eea 
>   ui/scripts/ui/events.js bd609d2 
>   ui/scripts/ui/utils.js 39ef3e3 
>   ui/scripts/ui/widgets/cloudBrowser.js 9a56bb3 
>   ui/scripts/ui/widgets/dataTable.js 1b3ea82 
>   ui/scripts/ui/widgets/detailView.js 0bccef5 
>   ui/scripts/ui/widgets/listView.js bc68a72 
>   ui/scripts/ui/widgets/multiEdit.js 08bd0bf 
>   ui/scripts/ui/widgets/notifications.js 0299603 
>   ui/scripts/ui/widgets/overlay.js ecf12e6 
>   ui/scripts/ui/widgets/tagger.js 9af6fb7 
>   ui/scripts/ui/widgets/toolTip.js 6967acc 
>   ui/scripts/ui/widgets/treeView.js fa1ceb6 
>   ui/scripts/vm_snapshots.js c50c7e1 
>   ui/scripts/vpc.js e90d8a7 
>   ui/scripts/zoneWizard.js 04687fe 
> 
> Diff: https://reviews.apache.org/r/12721/diff/
> 
> 
> Testing
> -------
> 
> Compiled... previewed in browser, navigated the pages, checked everything looked normal.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message