cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request 12277: Add VHDX image support
Date Thu, 18 Jul 2013 13:36:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12277/#review23378
-----------------------------------------------------------

Ship it!


Committed to master with commit id 876a7b3361a17bc16b1342fdebbff0f0306674a6.

- Devdeep Singh


On July 15, 2013, 9:12 a.m., Donal Lafferty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12277/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add VHDX image support, which is missing from DiskFormat class, revised ImageFormat interface,
StorageManager implementation, and the application component spec.
> 
> NB:  applicationContext.xml.in can only be checked at runtime.  A non-Hyper-V user should
verify that it does not break anything.
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/applicationContext.xml.in 14255c1e7a50719757ffa4f3d6f27eaeacfde917

>   engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/DiskFormat.java
6be7a6bb49eb534b56cb9da9c88da5ffb7d00fa4 
>   engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/disktype/VHDX.java
PRE-CREATION 
>   engine/storage/src/org/apache/cloudstack/storage/image/format/VHDX.java PRE-CREATION

>   server/src/com/cloud/storage/StorageManagerImpl.java d9ef853a743c1bfbb1e8a3aa911f1f857985b15a

> 
> Diff: https://reviews.apache.org/r/12277/diff/
> 
> 
> Testing
> -------
> 
> Compiles and runs when using Hyper-V plugin.
> 
> Has not been run in non-Hyper-V scenarios.
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message