cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12499: CLOUDSTACK-3376: NPE: resource count calculation from the account manager on account cleanup
Date Thu, 18 Jul 2013 09:38:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12499/#review23366
-----------------------------------------------------------


Commit c9548e37885bee6abf62c515c910fe29f9fcd7c6 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9548e3 ]

CLOUDSTACK-3376: NPE: resource count calculation from the account manager on account cleanup

This issue is happing because of the steps the code follow to cleanup the account.
The cleanupAccount was deleting the entries from the resource_limit and
resource_count table and performing further cleaning afterwards. Ideally, deletion
of entries from resourceLimit and resourceCount should be the last step in
cleanupAccount process.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 21b1c9449a1289db9fa92c2ec76a936006100ab3)


- ASF Subversion and Git Services


On July 12, 2013, 9:13 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12499/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 9:13 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3376
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>     CLOUDSTACK-3376: NPE: resource count calculation from the account manager on account
cleanup
> 
>     This issue is happing because of the steps the code follow to cleanup the account.
>     The cleanupAccount was deleting the entries from the resource_limit and
>     resource_count table and performing further cleaning afterwards. Ideally, deletion
>     of entries from resourceLimit and resourceCount should be the last step in
>     cleanupAccount process.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/user/AccountManagerImpl.java 283e832 
> 
> Diff: https://reviews.apache.org/r/12499/diff/
> 
> 
> Testing
> -------
> 
> Steps I followed to test account cleanup scenario:
> 
> 1. Create a user account.
> 2. Login as user.
> 3. Register a template and deploy an instance using this registered template.
> 4. Create a project from this user account.
> 5. Go to project view
> 6. Register a template and create a volume in this project_account.
> 7. Logout and login as root-admin.
> 8. Delete the project manages by the user account.
> 9. Delete the user account.
> 
> In MS logs, verified that cleanupAccount is happing properly.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message