cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536
Date Wed, 17 Jul 2013 07:37:30 GMT


> On July 17, 2013, 5:38 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 202
> > <https://reviews.apache.org/r/12427/diff/3/?file=319814#file319814line202>
> >
> >     Please clarify - Are they not at cluster level anymore ?

These are cluster level parameters but can be modified only using UpdateCluster API since
this needs some other updates not just DB change that we do in UpdateConfiguration.


> On July 17, 2013, 5:38 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 3243
> > <https://reviews.apache.org/r/12427/diff/3/?file=319815#file319815line3243>
> >
> >     What was wrong here...why not taking it from Config ?

Since we have removed the scope of these parameters from cluster. This method cant be used
to get the value.


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23239
-----------------------------------------------------------


On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12427/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 10:56 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold
is not considering overcommit value
> 
> CLOUDSTACK-2536:  parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor
are redundant(cluster level)
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
>   server/src/com/cloud/configuration/Config.java d3ed718 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 30ee2d7 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 
> 
> Diff: https://reviews.apache.org/r/12427/diff/
> 
> 
> Testing
> -------
> 
> Tested locally both with actual usage and over committed values for memory. 
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message