cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sheng Yang" <sh...@yasker.org>
Subject Re: Review Request 12517: Fix checks for already existing primary and secondary pvlan id on vmware DVS in pvlan setup
Date Mon, 15 Jul 2013 23:08:57 GMT


> On July 15, 2013, 11:08 p.m., Sheng Yang wrote:
> > Ship It!

Committed to the 4.2/MASTER.


- Sheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12517/#review23188
-----------------------------------------------------------


On July 15, 2013, 10:41 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12517/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 10:41 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, edison su, Kelven Yang, Sateesh Chodapuneedi,
and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-3311
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> An incorrect type check for an existing promiscuous pvlan id was causing Virtual Router
reboot failure. Fixing the same. Also detected incomplete checking of existing secondary pvlan
id on a VMWare DVS, so fixing that as well.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dc1486a 
> 
> Diff: https://reviews.apache.org/r/12517/diff/
> 
> 
> Testing
> -------
> 
> Created a pvlan setup in vmware. Created guest instances successfully. Restarted the
virtual router of the pvlan shared network. The VR rebooted successfully without erroring
out. Created multiple pvlan networks and associated guest VMs and restarted the VRs, all rebooted
successfully. Created guest VMs with multiple pvlan networks in each and they also worked
as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message