cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 12369: Ignore network interfaces without uuids when passing extra config to ESX for nvp
Date Mon, 15 Jul 2013 08:30:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12369/#review23142
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Trippaers


On July 9, 2013, 7:59 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12369/
> -----------------------------------------------------------
> 
> (Updated July 9, 2013, 7:59 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and
Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-3425
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The VR gets plumbed with 5 interfaces (passed to vmware resource as nicTOs) but only
three of them are initialized. The other two aren't used rightaway until configured later.
The extra configs being built and passed on to ESX as part of NVP integration is copying over
all the 5 nic configs but two of them don't have uuids, so the VM reconfigure task fails because
of unset values of nvp-iface* and VR startup fails. Fixing this by ignoring those unused interfaces
when building extra configs.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
372cc1b 
> 
> Diff: https://reviews.apache.org/r/12369/diff/
> 
> 
> Testing
> -------
> 
> With the fix, the VR comes up successfully, and guest VMs get created.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message