cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Likitha Shetty" <likitha.she...@citrix.com>
Subject Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when config items are added
Date Fri, 12 Jul 2013 11:20:06 GMT


> On July 12, 2013, 11:08 a.m., Kishan Kavala wrote:
> > Looks good to me

Thanks for reviewing Kishan.


- Likitha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23078
-----------------------------------------------------------


On July 12, 2013, 10:56 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 10:56 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-2757
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.

> Hence it will be set to 'Advanced' which is the default which will lead to encryption
failures if encryption is enabled. 
> Also cleaned up the code to use VO/DAO instead of SQL.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae 
> 
> Diff: https://reviews.apache.org/r/12504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message