cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
Date Thu, 11 Jul 2013 04:14:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/#review22993
-----------------------------------------------------------


Commit 4d4bd8a263b974daf53a60a1590f22c96bdd5e48 in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d4bd8a ]

CLOUDSTACK-3384: Fix the vlan range < 4096

VLAN ranges beyond 4095 are properly handled. Fix the test to accomdate
this change

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 3f5c1c6da3d2152fdc966603f929c3ea880d8b60)


- ASF Subversion and Git Services


On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12278/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 8:14 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo
Trippaers, and Sheng Yang.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
> 
> There're VLAN range check code in com.cloud.network.NetworkServiceImpl. 
> But it allows VLAN range between 0-4096. 
> 
> VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) . 
> CloudStack should return error when someone try to assign VLAN ID 4096 to network. 
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 05df742 
> 
> Diff: https://reviews.apache.org/r/12278/diff/
> 
> 
> Testing
> -------
> 
> Trying to create zone with Guest VLAN range 4090-4096 from WebUI.
> 
> updatePhysicalNetwork returns error correctly.
> 
> 
> Thanks,
> 
> Toshiaki Hatano
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message