cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Review Request 12348: Fix for NPE when listing eligible primary storage pools for volume migration across primary storages
Date Tue, 09 Jul 2013 02:53:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12348/
-----------------------------------------------------------

Review request for cloudstack, Chip Childers, Kelven Yang, rajeshbabu chintaguntla, and Sateesh
Chodapuneedi.


Bugs: CLOUDSTACK-3264


Repository: cloudstack-git


Description
-------

When listing zone wide primary storages for volume migration, a null pointer exception is
encountered because the listing of the eligible storage pools missed taking into account the
absence of cluster id for zone wide primary pools. Fixing the same and putting in appropriate
checks for other storage type allocators.

Note: This fix is for the master-6-17-stable branch. It is to be seen whether this fix is
required for master and if so, needs to be ported/tested on the same.


Diffs
-----

  engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
5326701 
  engine/storage/src/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java
5b1f8cd 
  engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java
632ba43 
  plugins/storage-allocators/random/src/org/apache/cloudstack/storage/allocator/RandomStoragePoolAllocator.java
cbe6647 
  server/src/com/cloud/server/ManagementServerImpl.java 682332c 

Diff: https://reviews.apache.org/r/12348/diff/


Testing
-------

Created multiple zone wide primary storages and confirmed that they show up as eligible destinations
when attempting to migrate a volume currently resident on a zone wide primary storage pool.
Created mixed zone-wide and cluster-wide primary storages to ensure nothing broke there. Observed
that volumes on a zone wide primary can only be moved to other zone wide primary pools and
similarly with cluster wide pools. Created new guest VM to confirm that existing primary code
paths work correctly with the changes in place.


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message