cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng
Date Mon, 08 Jul 2013 17:03:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12251/#review22836
-----------------------------------------------------------



server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/12251/#comment46541>

    Not calling the Transaction start here. i broke them into smaller transactions. Also not
holing the transaction while sending the command to the backend.


- bharat kumar


On July 4, 2013, 2:09 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12251/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 2:09 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Incorporating the review comments given by Alena and Sheng.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java a06208b 
>   api/src/com/cloud/network/NetworkService.java 405cecd 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 
>   server/src/com/cloud/network/NetworkManagerImpl.java 708c03d 
>   server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 
> 
> Diff: https://reviews.apache.org/r/12251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message