cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Toshiaki Hatano" <toshiaki.hat...@verio.net>
Subject Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.
Date Fri, 05 Jul 2013 20:14:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12278/
-----------------------------------------------------------

Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers,
and Sheng Yang.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'.

There're VLAN range check code in com.cloud.network.NetworkServiceImpl. 
But it allows VLAN range between 0-4096. 

VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) . 
CloudStack should return error when someone try to assign VLAN ID 4096 to network. 


Diffs
-----

  server/src/com/cloud/network/NetworkServiceImpl.java 05df742 

Diff: https://reviews.apache.org/r/12278/diff/


Testing
-------

Trying to create zone with Guest VLAN range 4090-4096 from WebUI.

updatePhysicalNetwork returns error correctly.


Thanks,

Toshiaki Hatano


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message