cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request 12223: Async jobs actions now trigger event bus messages to be published
Date Fri, 05 Jul 2013 16:42:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12223/#review22785
-----------------------------------------------------------

Ship it!


70f33efa7250d1ac8022f4390cddcbcb62ba92f8 master
e7c8a35c3aca4722666c6f6ff6bc9caac46e17c3 4.2

- Murali Reddy


On July 3, 2013, 3:58 p.m., Ryan Dietrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12223/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 3:58 p.m.)
> 
> 
> Review request for cloudstack, Marcus Sorensen and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-3190
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Updated AsyncJobManagerImpl to publish async job events when async jobs are created,
updated and completed.
> I am currently stashing the command event description in the commandInfo structure, and
then pulling it back out as needed.
> I could switch this to make a database change, but that seemed like a more invasive change.
> 
> I have further diffs to clean up ActionEvent and AlertEvent as well.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/event/EventCategory.java cee6529 
>   server/src/com/cloud/api/ApiServer.java 0cd1d61 
>   server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a 
> 
> Diff: https://reviews.apache.org/r/12223/diff/
> 
> 
> Testing
> -------
> 
> Manual testing only at this point.  I am more than willing to write a python test using
marvin, but I'm unsure if marvin has rabbitmq library support or not yet.  Please advise.
> 
> 
> Thanks,
> 
> Ryan Dietrich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message