cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request 11942: ProcessUtil cleanup
Date Thu, 04 Jul 2013 21:34:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11942/
-----------------------------------------------------------

(Updated July 4, 2013, 9:34 p.m.)


Review request for cloudstack.


Changes
-------

added assertions to positive test


Repository: cloudstack-git


Description
-------

- possible resource leak closed
- file content read uses now commons-lang FileUtils
- Added unit tests


Diffs (updated)
-----

  utils/src/com/cloud/utils/ProcessUtil.java c9fdf35 
  utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11942/diff/


Testing
-------

test included


Thanks,

Laszlo Hornyak


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message