cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 12271: CLOUDSTACK-2884: Resolved type conversion issue in test_service_offerings.py:test_04_change_offering_small
Date Thu, 04 Jul 2013 14:46:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12271/#review22770
-----------------------------------------------------------


Commit 05173a68892d28ae6c0854c981c6248a79ac8e0b in branch refs/heads/master-6-17-stable from
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=05173a6 ]

CLOUDSTACK-2884: Fixed test_04_change_offering_small

Added method to compare if two digits are almost equal within given range

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
(cherry picked from commit 048cf5aae84786d2d3515a3199271e87c0c7bafb)


- ASF Subversion and Git Services


On July 4, 2013, 10:33 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12271/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 10:33 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Resolved Issue 2884: Test case "test_service_offerings.py:test_04_change_offering_small
for VMWare and KVM.
> Earlier there was str to int type conversion issue for assertAlmostEqual function. Now
instead of that, I have added own function to check if the two digits are almost equal within
particular range.
> 
> During execution of test case, it was observed that there is difference of 10 in total_memory
and offering memory. I have set range as 20.
> 
> The test case runs fine on KVM and VMware.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_service_offerings.py 0213c04 
> 
> Diff: https://reviews.apache.org/r/12271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message