cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 12243: CLOUDSTACK-3184: updateVirtualMachine api gives java NPE.
Date Wed, 03 Jul 2013 14:33:11 GMT


> On July 3, 2013, 2:09 p.m., Prasanna Santhanam wrote:
> > 31df729008c748e6eafe49ff86e1da618013c551 for the fix.
> > 
> > Added an integration test to back up the API issue:9f0c9ee20c1a65d427702a330798512e7297e322

Test passes after the fix. Please close the review as submitted.

$ nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/component/test_update_vm.py
--load
Test Update VirtualMachine Name ... ok

----------------------------------------------------------------------
Ran 1 test in 21.552s

OK


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12243/#review22718
-----------------------------------------------------------


On July 3, 2013, 11:21 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12243/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 11:21 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3184
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3184: updateVirtualMachine api gives java NPE.
> 
> This bug is not reproducible from CloudStack UI. Steps to reproduce this bug:
> 
> 1. Deploy a VM without passing any parameters in Name and Description (last step in deploy
VM wizard).
> 2. Stop this VM.
> 3. Fire updateVIrtualMachine API without passing "displayName" parameter, you'll see
NPE in MS logs. Do not try  with UI because UI will pass displayName paramter with blank value.
> 
> There isn't any null check for displayName parameter and it is null because initially
it was not set during the VM deployment and afterwards we are not passing displayName paramter
in the API.
> 
> So added null check for displayName in if condition.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java a59fa5b 
> 
> Diff: https://reviews.apache.org/r/12243/diff/
> 
> 
> Testing
> -------
> 
> Same as Steps mentioned in the description.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message