cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Re: Review Request 12180: Fix NPE when adding invalid primary datastore
Date Wed, 03 Jul 2013 00:25:28 GMT


> On June 29, 2013, 7:33 a.m., Prasanna Santhanam wrote:
> > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java,
line 59
> > <https://reviews.apache.org/r/12180/diff/1/?file=313061#file313061line59>
> >
> >     This block should simply be:
> >     
> >             if (dataStoreVO == null) {
> >                 throw new CloudRuntimeException("Unable to locate primary datastore
with id " + dataStoreVO.getId());	
> >             }	
> >             String providerName = dataStoreVO.getStorageProviderName();
> 
> Sateesh Chodapuneedi wrote:
>     Use dataStoreId instead of dataStoreVO.getId() in exception message

Will make these changes and resubmit the patch. Thanks Sateesh, Prasanna!


- Venkata Siva Vijayendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22563
-----------------------------------------------------------


On July 3, 2013, 12:25 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12180/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 12:25 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and Sateesh
Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3110
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing an NPE when an attempt is made to add a primary datastore by providing an unreachable/nonexistent
datastore/host.
> 
> 
> Diffs
> -----
> 
>   engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
71df262 
>   engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
06b54e0 
> 
> Diff: https://reviews.apache.org/r/12180/diff/
> 
> 
> Testing
> -------
> 
> With fix in place, an attempt to add an invalid primary datastore will fail with a GUI
error dialog instead of failing silently with an NPE in the mgmt server log.
> 
> 
> File Attachments
> ----------------
> 
> Refactored patch for master-6-17-stable branch
>   https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message