cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request 12191: removed EnumerationImpl
Date Tue, 02 Jul 2013 20:22:53 GMT


> On July 1, 2013, 3:07 p.m., Hugo Trippaers wrote:
> > Ship It!
> 
> Hugo Trippaers wrote:
>     master: 16b7509a234158b536155be9278cfee33b93a5c7
>     4.2: 00e99a08169b60b0449d67dfc891053cf4469bf7
> 
> Hugo Trippaers wrote:
>     This was the wrong patch, this is the removed CleanupDelegate patch.  Can you submit
the right patch for this review?

oops, indeed! Sorry!
Sending again.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/#review22600
-----------------------------------------------------------


On June 29, 2013, 5:05 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12191/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 5:05 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> EnumerationImpl was not used and duplicates functionality
> with org.apache.commons.collections.iterators.EnumerationIterator
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3 
> 
> Diff: https://reviews.apache.org/r/12191/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message