cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sowmya Krishnan <sowmya.krish...@citrix.com>
Subject RE: Review Request 12874: Fix reboot failures with wait time
Date Wed, 24 Jul 2013 17:06:39 GMT
RB doesn’t accept the patch. Keeps failing. Here's the patch:

From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001
From: Sowmya Krishnan <sowmya.krishnan@citrix.com>
Date: Tue, 23 Jul 2013 22:29:10 +0530
Subject: [PATCH] Add wait while Netscaler recognizes service to be up

---
 test/integration/component/test_netscaler_lb.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/test/integration/component/test_netscaler_lb.py b/test/integration/component/test_netscaler_lb.py
index cd85659..d93a262 100644
--- a/test/integration/component/test_netscaler_lb.py
+++ b/test/integration/component/test_netscaler_lb.py
@@ -2772,6 +2772,8 @@ class TestVmWithLb(cloudstackTestCase):
         self.debug("Rebooting VM instance: %s" % self.vm_2.name)
         self.vm_2.reboot(self.apiclient)
         self.debug("Rebooting VM: %s" % self.vm_2.name)
+        self.debug("Waiting for Netscaler to get the service up")
+        time.sleep( 120 )
 
         try:
             self.debug(
-- 
1.7.5.4


> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf Of
> Prasanna Santhanam
> Sent: Wednesday, July 24, 2013 9:56 PM
> To: Prasanna Santhanam
> Cc: cloudstack; Sowmya Krishnan
> Subject: Re: Review Request 12874: Fix reboot failures with wait time
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12874/#review23766
> -----------------------------------------------------------
> 
> 
> I think you forgot to attach the diff here.
> 
> - Prasanna Santhanam
> 
> 
> On July 23, 2013, 5:20 p.m., Sowmya Krishnan wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/12874/
> > -----------------------------------------------------------
> >
> > (Updated July 23, 2013, 5:20 p.m.)
> >
> >
> > Review request for cloudstack and Prasanna Santhanam.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > Fix reboot failures with sleep time since Netscaler at times takes almost 60 -
> 90 seconds for identifying the service to be up after rebooting a VM.
> >
> >
> > Diffs
> > -----
> >
> >
> > Diff: https://reviews.apache.org/r/12874/diff/
> >
> >
> > Testing
> > -------
> >
> > Tested locally and the script now passes
> >
> >
> > Thanks,
> >
> > Sowmya Krishnan
> >
> >

Mime
View raw message