Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of shadowsor@gmail.com
 designates 209.85.128.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20130424233015.22503.93631@reviews.apache.org>
References: <20130424232928.22503.2016@reviews.apache.org>
	<20130424233015.22503.93631@reviews.apache.org>
Date: Fri, 28 Jun 2013 11:27:40 -0600
Message-ID: 
 <CALFpzo5q6bJ52DEu6j+3FQcUjaVhUFrKtt5kW0o1ej29hRU1PA@mail.gmail.com>
Subject: Re: Review Request: Remove 2k limitation for user data on a
 deployVMCmd issued as an HTTP POST request
From: Marcus Sorensen <shadowsor@gmail.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>,
 Min Chen <min.chen@citrix.com>
Cc: Kelven Yang <kelven.yang@citrix.com>,
 Chip Childers <chipchilders@apache.org>,
	Hugo Trippaers <htrippaers@schubergphilis.com>,
	Venkata Siva Vijayendra Bhamidipati <vijayendra.bhamidipati@citrix.com>,
	cloudstack <cloudstack-dev@incubator.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Anything special required to do this POST? Just read this thread when
searching for "userdata 2k" and noticed that POST is supposed to be
supported, but if I run the following it doesn't work:

 curl --request POST 'http://localhost:8096/client/api' --data
'command=3DlistVirtualMachines'


On Wed, Apr 24, 2013 at 5:30 PM, Min Chen <min.chen@citrix.com> wrote:
>
>
>> On April 24, 2013, 11:29 p.m., Min Chen wrote:
>> > Ship It!
>
> Prasanna has fixed the marvin test and pushed to master.
> These are the rebased commits on master:
> 4e9e7937ed5e56cbd7f678b2ed9863a56af16635 Fix Vijay's test to use the marv=
in integratin libararies
> b0caae6b33347f36721f28dca1fa12e7b18f1cd1 CLOUDSTACK-1086: DeployVirtualMa=
chine userdata enhancements
>
>
> - Min
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10294/#review19680
> -----------------------------------------------------------
>
>
> On April 23, 2013, 9:45 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10294/
>> -----------------------------------------------------------
>>
>> (Updated April 23, 2013, 9:45 p.m.)
>>
>>
>> Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yan=
g, and Min Chen.
>>
>>
>> Description
>> -------
>>
>> Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/D=
eployVirtualMachine+userdata+enhancements for a background on the requireme=
nts driving this patch.
>>
>> This patch hasn't been extensively tested yet, and I will update this re=
quest with more info. I am uploading a first diff for initial review/commen=
ts.
>>
>>
>> This addresses bug CLOUDSTACK-1086.
>>
>>
>> Diffs
>> -----
>>
>>   api/src/com/cloud/vm/UserVmService.java aa21136
>>   api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680
>>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 70c=
0159
>>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ff8=
fff1
>>   core/src/com/cloud/vm/UserVmVO.java a16eaf9
>>   server/src/com/cloud/api/ApiDispatcher.java 925d90a
>>   server/src/com/cloud/api/ApiServer.java d842819
>>   server/src/com/cloud/api/ApiServerService.java 12d8b52
>>   server/src/com/cloud/api/ApiServlet.java 03bfb5f
>>   server/src/com/cloud/vm/UserVmManagerImpl.java 1843f60
>>   server/test/com/cloud/vm/MockUserVmManagerImpl.java 0d0a8f4
>>   server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180
>>   server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREAT=
ION
>>   server/test/resources/UserVMDaoTestContext.xml PRE-CREATION
>>   setup/db/db/schema-410to420.sql 10cdbba
>>   test/integration/component/test_deploy_vm_with_userdata.py PRE-CREATIO=
N
>>
>> Diff: https://reviews.apache.org/r/10294/diff/
>>
>>
>> Testing
>> -------
>>
>> Manual testing done with scripts generating large/small userdata during =
creation of VMs, with both GET and POST requests confirmed to work correctl=
y, on both integration port and the 8080 port.
>>
>> Basic Marvin test to create a VM with user data has been written. Since =
marvin doesn't yet support POSTable APIs, as soon as that is made available=
 for create/update VM operations, marvin tests will be written for the same=
. Requesting that this be noted as an AI for the future.
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>>
>>
>