Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of rajesh.battala@citrix.com
 designates 203.166.19.134 as permitted sender)
From: Rajesh Battala <rajesh.battala@citrix.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>
Subject: RE: Regarding ssvm-check script
Thread-Topic: Regarding ssvm-check script
Thread-Index: Ac5oWNpVfjsqCXTRTd+GSC7Yy1XHzQAW/o+AAAcxscA=
Date: Fri, 14 Jun 2013 07:36:46 +0000
Message-ID: <8CCE9859D2CAFD45948DBF7145AFB98C0F22AE@SINPEX01CL01.citrite.net>
References: <pt5dvq3ydyqqn0qrnv5ohwow.1371141830065@email.android.com>
 <CDE0B6E1.1DD96%nitin.mehta@citrix.com>
In-Reply-To: <CDE0B6E1.1DD96%nitin.mehta@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Nitin,=20
Yes, the ssvm under console proxy should be removed. It make more sense for=
 the script to be coming from secondary-storage folder path.=20
If you are removing the script under consoleproxy, make the change in the s=
ystemvm-description.xml to pick the ssvm script from the secondary storage =
scripts.=20
If you don't make that change systemvm.iso might not have the ssvm script.

Thanks
Rajesh Battala

> -----Original Message-----
> From: Nitin Mehta [mailto:Nitin.Mehta@citrix.com]
> Sent: Friday, June 14, 2013 12:09 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Regarding ssvm-check script
>=20
> Hi Rajesh,
> Please find my comments inline
>=20
> On 13/06/13 10:40 PM, "Rajesh Battala" <rajesh.battala@citrix.com> wrote:
>=20
> >Hi All,
> >While fixing an issue ( https://reviews.apache.org/r/11862/ )in
> >ssvm-check script I figured out some issues.
> >
> >1.There are two ssvm_check scripts(duplicates).
> >
> >./services/console-proxy/server/scripts/ssvm-check.sh
> >./services/secondary-storage/scripts/ssvm-check.sh
> >
> >When building the code, these scripts will go to systemvm.zip,
> >systemvm.zip will be packaged into systemvm.iso.
> >
> >systemvm-descriptor.xml will define what all the scripts should package.
> >As per the descriptor xml,  the ssvm-check script under console-proxy
> >is getting into systemvm.zip.
>=20
> Shouldn't it be the other way round ? I mean the ssvm script under
> secondary-storage should have come in ?
>=20
> >
> >I had verified the ssvm-check script with the fix under console-proxy.
> >The systemvm.zip is getting update properly and making into systemvm.iso=
.
> >And ssvm is getting the right script now.
> >
> >Changes made in script under
> >./services/secondary-storage/scripts/ssvm-check.sh is not getting into
> >systemvm.iso
> >
> >I feel the script is redundant and creating confusion.
> >Can we remove the script in one location?
>=20
> I would remove it from console-proxy for the sake of consistency and make
> sure the one under secondary-storage gets in. Also while doing so hopeful=
ly
> the final location (folder structure) of the script is not disturbed in t=
he ssvm
>=20
> >
> >Thanks
> >Rajesh Battala